linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sm8350-microsoft-surface: fix USB dual-role mode property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d90448f8-9bc4-3a14-1915-a18c2cba100a@linaro.org>
Date:   Sat, 4 Mar 2023 14:06:22 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jianhua Lu <lujianhua000@...il.com>,
        Katherine Perez <kaperez@...ux.microsoft.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8350-microsoft-surface: fix USB
 dual-role mode property



On 4.03.2023 14:03, Krzysztof Kozlowski wrote:
> The "dr_mode" is a property of USB DWC3 node, not the Qualcomm wrapper
> one:
>   sm8350-microsoft-surface-duo2.dtb: usb@...8800: 'dr_mode' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Fixes: c16160cfa565 ("arm64: dts: qcom: add minimal DTS for Microsoft Surface Duo 2")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
> index b536ae36ae6d..3bd5e57cbcda 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
> @@ -341,6 +341,9 @@ &ufs_mem_phy {
>  
>  &usb_1 {
>  	status = "okay";
> +};
> +
> +&usb_1_dwc3 {
>  	dr_mode = "peripheral";
>  };
>