linux-kernel - [PATCH] gfs2: remove extern from free_local_statfs_inodes and find_local_statfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230304132625.1936034-1-trix@redhat.com>
Date:   Sat,  4 Mar 2023 08:26:25 -0500
From:   Tom Rix <trix@...hat.com>
To:     rpeterso@...hat.com, agruenba@...hat.com
Cc:     cluster-devel@...hat.com, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] gfs2: remove extern from free_local_statfs_inodes and find_local_statfs_inode

smatch reports
fs/gfs2/super.c:1477:13: warning: function 'free_local_statfs_inodes' with external linkage has definition
fs/gfs2/super.c:1492:21: warning: function 'find_local_statfs_inode' with external linkage has definition

extern is only needed in a declaration, so remove them.

Signed-off-by: Tom Rix <trix@...hat.com>
---
 fs/gfs2/super.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index a83fa62106f0..189d7f7a4548 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -1474,7 +1474,7 @@ static void gfs2_free_inode(struct inode *inode)
 	kmem_cache_free(gfs2_inode_cachep, GFS2_I(inode));
 }
 
-extern void free_local_statfs_inodes(struct gfs2_sbd *sdp)
+void free_local_statfs_inodes(struct gfs2_sbd *sdp)
 {
 	struct local_statfs_inode *lsi, *safe;
 
@@ -1489,8 +1489,8 @@ extern void free_local_statfs_inodes(struct gfs2_sbd *sdp)
 	}
 }
 
-extern struct inode *find_local_statfs_inode(struct gfs2_sbd *sdp,
-					     unsigned int index)
+struct inode *find_local_statfs_inode(struct gfs2_sbd *sdp,
+				      unsigned int index)
 {
 	struct local_statfs_inode *lsi;
 
-- 
2.27.0