linux-kernel - Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230304020152.GB5231@google.com>
Date:   Sat, 4 Mar 2023 11:01:52 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Yosry Ahmed <yosryahmed@...gle.com>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness
 grouping

On (23/03/03 15:28), Andrew Morton wrote:
> Date: Fri, 3 Mar 2023 15:28:33 -0800
> From: Andrew Morton <akpm@...ux-foundation.org>
> To: Yosry Ahmed <yosryahmed@...gle.com>
> Cc: Sergey Senozhatsky <senozhatsky@...omium.org>, Minchan Kim
>  <minchan@...nel.org>, linux-kernel@...r.kernel.org, linux-mm@...ck.org
> Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based
>  fullness grouping
> Message-Id: <20230303152833.24d7a42102bd712e09f95cd5@...ux-foundation.org>
> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
> 
> On Fri, 3 Mar 2023 08:58:55 -0800 Yosry Ahmed <yosryahmed@...gle.com> wrote:
> 
> > > > +               for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
> > > > +                       class_almost_full = zs_stat_get(class, fg);
> > > > +               for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
> > > > +                       class_almost_empty = zs_stat_get(class, fg);
> > >
> > > Aren't these supposed to be += ?

Good catch Yosry! Thanks for taking a look.

> I'll fix that up anyway, to avoid a bisection hole.  And in case [patch 4/4]
> gets dropped from the series or is later reverted or whatever.

Thanks Andrew, should I just send out a v4 with 3/4 and 4/4 fixed up?