linux-kernel - Re: [PATCH 0/3] watchdog: Simplify using devm_watchdog_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c1f9813-7f65-6a45-45fc-3d6edf8f2496@roeck-us.net>
Date:   Mon, 6 Mar 2023 10:21:58 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com, kernel@...gutronix.de
Subject: Re: [PATCH 0/3] watchdog: Simplify using
 devm_watchdog_register_device()

On 3/6/23 09:08, Uwe Kleine-König wrote:
> Hello,
> 
> this series converts three drivers to use
> devm_watchdog_register_device(). This allows to drop their remove
> callback.
> 

Side note: We could do more of the same by also replacing pm_runtime_enable()
with devm_pm_runtime_enable(), only I don't know if the additional
call to pm_runtime_dont_use_autosuspend() in its disable callback would
be a functional change. I also don't know if pm_runtime_put() in the remove
function is necessary or if it even makes sense. Any idea ?

Thanks,
Guenter

> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>    watchdog: bcm47xx: Simplify using devm_watchdog_register_device()
>    watchdog: rn5t618: Simplify using devm_watchdog_register_device()
>    watchdog: wm8350: Simplify using devm_watchdog_register_device()
> 
>   drivers/watchdog/bcm47xx_wdt.c | 12 +-----------
>   drivers/watchdog/rn5t618_wdt.c | 12 +-----------
>   drivers/watchdog/wm8350_wdt.c  |  9 +--------
>   3 files changed, 3 insertions(+), 30 deletions(-)
> 
> 
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6