linux-kernel - RE: [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR12MB38959136005B21C93159C5A8D7B69@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Mon, 6 Mar 2023 22:39:26 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>
CC:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()

 > Mon, Mar 06, 2023 at 04:12:37PM -0500, Asmaa Mnebhi kirjoitti:
> > bgpio_init() uses "sz" argument to populate ngpio, which is not
> > accurate. Instead, read the "ngpios" property from the DT and if it
> > doesn't exist, use the "sz" argument. With this change, drivers no
> > longer need to overwrite the ngpio variable after calling bgpio_init().
> 
> Thank you!
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Sorry it took a bit longer for us to settle on this.

Thank you Andy!