linux-kernel - Re: [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4b3d8b1-bbe5-2c47-46a9-a33ebec2492f@linaro.org>
Date:   Mon, 6 Mar 2023 22:56:26 +0000
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Stephan Gerhold <stephan@...hold.net>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        djakov@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, benl@...areup.com,
        shawn.guo@...aro.org, fabien.parent@...aro.org, leo.yan@...aro.org,
        dmitry.baryshkov@...aro.org
Subject: Re: [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua

On 06/03/2023 16:14, Stephan Gerhold wrote:
> There are*a lot*  of unused pinctrl entries here. If you don't reference
> them anywhere (by referencing them via label) they just waste space in
> the device tree. The GPIOs will still remain unconfigured.
> 
> Please save them locally for later usage and only keep the used entries.
> This will ease review of upcoming patches since these are better
> understandable together with the actual device node making use of them.

TBH, I really would have rather received this comment @ version 1, 
before doing all the work to sanitise the incoming downstream DTS.

But sure, no problem, I'll drop.

---
bod