lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZAZvH6CFtH4I1BOm@surfacebook>
Date:   Tue, 7 Mar 2023 00:54:23 +0200
From:   andy.shevchenko@...il.com
To:     Lizhe <sensor1010@....com>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, geert+renesas@...der.be,
        info@...ux.net, shc_work@...l.ru, j-keerthy@...com,
        hoan@...amperecomputing.com, fancer.lancer@...il.com,
        orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com, kaloz@...nwrt.org, khalasa@...p.pl,
        keguang.zhang@...il.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH v1] drivers/gpio: remove redundant platform_set_drvdata()

Mon, Mar 06, 2023 at 11:15:32PM +0800, Lizhe kirjoitti:
> remove redundant platform_set_drvdata(),
> Because there is no place to use the platform_get_drvdata

The commit message has to be improved:
- English grammar and punctuation
- style of func()
- clearer wording on what it all means

Note, to get driver data the dev_get_drvdata() can be used. Do you aware about
this? And hHow did you check these drivers?

-- 
With Best Regards,
Andy Shevchenko


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ