linux-kernel - Re: [PATCH v1] drivers/gpio: remove redundant platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MemEXVcqL0axaduTrAZhT1Zx6APCY_qo2TM2E-aD=Seqw@mail.gmail.com>
Date:   Wed, 8 Mar 2023 11:26:14 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     andy.shevchenko@...il.com
Cc:     Lizhe <sensor1010@....com>, linus.walleij@...aro.org,
        geert+renesas@...der.be, info@...ux.net, shc_work@...l.ru,
        j-keerthy@...com, hoan@...amperecomputing.com,
        fancer.lancer@...il.com, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        kaloz@...nwrt.org, khalasa@...p.pl, keguang.zhang@...il.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v1] drivers/gpio: remove redundant platform_set_drvdata()

On Mon, Mar 6, 2023 at 11:54 PM <andy.shevchenko@...il.com> wrote:
>
> Mon, Mar 06, 2023 at 11:15:32PM +0800, Lizhe kirjoitti:
> > remove redundant platform_set_drvdata(),
> > Because there is no place to use the platform_get_drvdata
>
> The commit message has to be improved:
> - English grammar and punctuation
> - style of func()
> - clearer wording on what it all means
>
> Note, to get driver data the dev_get_drvdata() can be used. Do you aware about
> this? And hHow did you check these drivers?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I would also add to that: you need to use your full first and family
name in SoB because I assume you don't just go by "Lizhe".

Bartosz