linux-kernel - [PATCH 0/2] spi: imx: Fix cleanup in remove and convert to .remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230306065733.2170662-1-u.kleine-koenig@pengutronix.de>
Date:   Mon,  6 Mar 2023 07:57:31 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Mark Brown <broonie@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Stefan Agner <stefan@...er.ch>
Cc:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH 0/2] spi: imx: Fix cleanup in remove and convert to .remove_new()

From: Uwe Kleine-König <uwe@...ine-koenig.org>

Hello,

this small series converts the spi-imx driver to .remove_new(). The
motivation for this tree-wide effort are drivers that don't properly
cleanup and return an error code. This is broken as this results in
resource leaks. The spi-imx driver is such a driver. The idea is that if
the remove callback returns void it's obvious that an early error return
is wrong.

Best regards
Uwe

Uwe Kleine-König (2):
  spi: imx: Don't skip cleanup in remove's error path
  spi: imx: Convert to platform remove callback returning void

 drivers/spi/spi-imx.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)


base-commit: b01fe98d34f3bed944a93bd8119fed80c856fad8
-- 
2.39.1