linux-kernel - Re: [PATCH] btf: fix resolving BTF_KIND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN+4W8hX4V+VTMFjE-1WUVrpHoh1G_e07cTArL5W4AKwVNr0_w@mail.gmail.com>
Date:   Mon, 6 Mar 2023 09:26:25 +0000
From:   Lorenz Bauer <lorenz.bauer@...valent.com>
To:     Martin KaFai Lau <martin.lau@...ux.dev>
Cc:     Lorenz Bauer <lmb@...valent.com>, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT,
 UNION, PTR

On Fri, Mar 3, 2023 at 12:16 AM Martin KaFai Lau <martin.lau@...ux.dev> wrote:
>
> lgtm. Could it be moved out of the for loop?

Yeah, that is possible I think, since we can only trigger the problem if

    return env_stack_push()

Is executed. I'll send a v2.

> Please add the test case described in the commit message to the prog_tests/btf.c.

Good point, I'll send this as a separate commit. Backporting patches
doesn't work well in my experience.

Thanks for your review!
Lorenz