linux-kernel - Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230306092652.GP68926@ediswmail.ad.cirrus.com>
Date:   Mon, 6 Mar 2023 09:26:52 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
CC:     James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        Ricardo Rivera-Matos <rriveram@...nsource.cirrus.com>
Subject: Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support

On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@...nsource.cirrus.com>
> 
> The CS35L45 digital core incorporates one programmable DSP block,
> capable of running a wide range of audio enhancement and speaker
> and battery protection functions.
> 
> Signed-off-by: Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
> ---
> +#define CS35L45_DAC_MUX_ROUTE(name) \
> +	{ name" Source", "ASP_RX1",	"ASP_RX1" }, \
> +	{ name" Source", "ASP_RX2",	"ASP_RX2" }, \
> +	{ name" Source", "DSP_TX1",	"DSP1" }, \
> +	{ name" Source", "DSP_TX2",	"DSP1" }
> +
> +

Minor nit, double blank line here.

But otherwise looks pretty good to me:

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles