linux-kernel - Re: [PATCH 20/24] kbuild, gpio: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfEVgF+6NyAB=3g3_mFvfppHg45LNnvopO_SwqdeNFgkA@mail.gmail.com>
Date:   Mon, 6 Mar 2023 10:58:07 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Nick Alcock <nick.alcock@...cle.com>
Cc:     mcgrof@...nel.org, linux-modules@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-unisoc@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 20/24] kbuild, gpio: remove MODULE_LICENSE in non-modules

On Fri, Feb 17, 2023 at 3:12 PM Nick Alcock <nick.alcock@...cle.com> wrote:
>
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>

Applied, thanks!

Bart