linux-kernel - Re: [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Mar 2023 12:11:51 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Melody Olvera <quic_molvera@...cinc.com>,
        Souradeep Chowdhury <quic_schowdhu@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties



On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> Nods with unit addresses must have also 'reg' property:
> 
>   sc7280-herobrine-crd.dtb: eud@...0000: ports:port@0: 'reg' is a required property
> 
> Fixes: 0b059979090d ("arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
This could use some newlines, but that's a different topic.

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index bdcb74925313..71179182c3b8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3593,12 +3593,17 @@ eud: eud@...0000 {
>  			      <0 0x088e2000 0 0x1000>;
>  			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
>  			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
>  				port@0 {
> +					reg = <0>;
>  					eud_ep: endpoint {
>  						remote-endpoint = <&usb2_role_switch>;
>  					};
>  				};
>  				port@1 {
> +					reg = <1>;
>  					eud_con: endpoint {
>  						remote-endpoint = <&con_eud>;
>  					};
> @@ -3609,7 +3614,11 @@ eud_con: endpoint {
>  		eud_typec: connector {
>  			compatible = "usb-c-connector";
>  			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
>  				port@0 {
> +					reg = <0>;
>  					con_eud: endpoint {
>  						remote-endpoint = <&eud_con>;
>  					};