linux-kernel - Re: [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16c1ed3b-4721-bc78-7f92-6b9faf8603e1@linaro.org>
Date:   Mon, 6 Mar 2023 14:49:43 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Melody Olvera <quic_molvera@...cinc.com>,
        Souradeep Chowdhury <quic_schowdhu@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight
 funnel properties



On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> There is only one output port, thus out-ports should not have
> 'address/sice-cells' and unit addresses.  'reg-names' are also not
s/sice/size

> allowed by bindings.
> 
>   qrb5165-rb5.dtb: funnel@...2000: out-ports: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
>   qrb5165-rb5.dtb: funnel@...4000: Unevaluated properties are not allowed ('reg-names' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 2f0e460acccd..88870d9e3348 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2799,11 +2799,7 @@ funnel@...2000 {
>  			clock-names = "apb_pclk";
>  
>  			out-ports {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -
> -				port@0 {
> -					reg = <0>;
> +				port {
>  					funnel_in1_out_funnel_merg: endpoint {
>  						remote-endpoint = <&funnel_merg_in_funnel_in1>;
>  					};
> @@ -2904,7 +2900,6 @@ funnel@...4000 {
>  			arm,primecell-periphid = <0x000bb908>;
>  
>  			reg = <0 0x06b04000 0 0x1000>;
> -			reg-names = "funnel-base";
>  
>  			clocks = <&aoss_qmp>;
>  			clock-names = "apb_pclk";
> @@ -3220,9 +3215,6 @@ funnel@...0000 {
>  			clock-names = "apb_pclk";
>  
>  			out-ports {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -
>  				port {
>  					funnel_apss_merg_out_funnel_in1: endpoint {
>  					remote-endpoint = <&funnel_in1_in_funnel_apss_merg>;