linux-kernel - Re: [PATCH] tty: do checkpatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZAdjGYtCA0eWRUMl@kroah.com>
Date:   Tue, 7 Mar 2023 17:15:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Atin Bainada <hi@...nb.me>
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: do checkpatch cleanup

On Tue, Mar 07, 2023 at 04:02:47PM +0000, Atin Bainada wrote:
> Signed-off-by: Atin Bainada <hi@...nb.me>
> ---
>  drivers/tty/tty_ioctl.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
> index 12983ce4e43e..05a4dd0db476 100644
> --- a/drivers/tty/tty_ioctl.c
> +++ b/drivers/tty/tty_ioctl.c
> @@ -73,7 +73,7 @@ EXPORT_SYMBOL(tty_chars_in_buffer);
>   *	the number of bytes written. If no method is provided 2K is always
>   *	returned and data may be lost as there will be no flow control.
>   */
> -
> +
>  unsigned int tty_write_room(struct tty_struct *tty)
>  {
>  	if (tty->ops->write_room)
> @@ -403,6 +403,7 @@ __weak int kernel_termios_to_user_termio(struct termio __user *termio,
>  						struct ktermios *termios)
>  {
>  	struct termio v;
> +
>  	memset(&v, 0, sizeof(struct termio));
>  	v.c_iflag = termios->c_iflag;
>  	v.c_oflag = termios->c_oflag;
> @@ -540,6 +541,7 @@ static void copy_termios_locked(struct tty_struct *tty, struct ktermios *kterm)
>  static int get_termio(struct tty_struct *tty, struct termio __user *termio)
>  {
>  	struct ktermios kterm;
> +
>  	copy_termios(tty, &kterm);
>  	if (kernel_termios_to_user_termio(termio, &kterm))
>  		return -EFAULT;
> @@ -919,6 +921,7 @@ static int __tty_perform_flush(struct tty_struct *tty, unsigned long arg)
>  int tty_perform_flush(struct tty_struct *tty, unsigned long arg)
>  {
>  	struct tty_ldisc *ld;
> +
>  	int retval = tty_check_change(tty);
>  	if (retval)
>  		return retval;
> --
> 2.39.2
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot