linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sdm845-oneplus-common: add PN553 NFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78de9402-d14a-4897-a602-9fd214c31c20@irl.hu>
Date:   Tue, 7 Mar 2023 20:04:04 +0100
From:   Gergo Koteles <soyer@....hu>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-oneplus-common: add PN553 NFC

On 2023. 03. 07. 20:02, Konrad Dybcio wrote:
> 
> 
> On 7.03.2023 19:59, Gergo Koteles wrote:
>> The OnePlus 6/6T both have a NQ330 (PN553 + P73N2M0).
>> The PN533 supported by the nxp-nci-i2c driver in mainline.
>> It detects/reads NFC tags using "nfctool".
>>
>> Signed-off-by: Gergo Koteles <soyer@....hu>
>> ---
> Next time include a changelog below this --- line detailing
> what changed between revisions.
> 
Okey. Thanks for the suggestion and the review.

> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> Konrad
>>   .../boot/dts/qcom/sdm845-oneplus-common.dtsi  | 39 +++++++++++++++++++
>>   1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index 64638ea94db7..5e45801031d8 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -380,6 +380,24 @@ zap-shader {
>>   	};
>>   };
>>   
>> +&i2c3 {
>> +	clock-frequency = <400000>;
>> +	status = "okay";
>> +
>> +	nfc@28 {
>> +		compatible = "nxp,nxp-nci-i2c";
>> +		reg = <0x28>;
>> +
>> +		interrupts-extended = <&tlmm 63 IRQ_TYPE_EDGE_RISING>;
>> +
>> +		enable-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
>> +		firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>;
>> +
>> +		pinctrl-0 = <&nfc_int_active &nfc_enable_active &nfc_firmware_active>;
>> +		pinctrl-names = "default";
>> +	};
>> +};
>> +
>>   &i2c10 {
>>   	status = "okay";
>>   	clock-frequency = <100000>;
>> @@ -753,6 +771,27 @@ &usb_1_hsphy {
>>   &tlmm {
>>   	gpio-reserved-ranges = <0 4>, <81 4>;
>>   
>> +	nfc_int_active: nfc-int-active-state {
>> +		pins = "gpio63";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-pull-up;
>> +	};
>> +
>> +	nfc_enable_active: nfc-enable-active-state {
>> +		pins = "gpio12";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-pull-up;
>> +	};
>> +
>> +	nfc_firmware_active: nfc-firmware-active-state {
>> +		pins = "gpio62";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-pull-up;
>> +	};
>> +
>>   	tri_state_key_default: tri-state-key-default-state {
>>   		pins = "gpio40", "gpio42", "gpio26";
>>   		function = "gpio";