linux-kernel - Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in scsi_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d119fcba-a323-d0cd-0d36-759ad2fb8252@acm.org>
Date:   Tue, 7 Mar 2023 14:35:09 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Zhong Jinghua <zhongjinghua@...weicloud.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhongjinghua@...weicloude.com, yi.zhang@...wei.com,
        yukuai3@...wei.com
Subject: Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in
 scsi_remove_target

On 3/6/23 04:16, Zhong Jinghua wrote:
> +			/*
> +			 * If the reference count is already zero, skip this
> +			 * target is safe  because scsi_target_destroy()
> +			 * will wait until the host lock has been released
> +			 * before freeing starget.
> +			 */

The above comment has grammatical issues and is confusing. I think the 
comment that I suggested was much better than the above.

Bart.