linux-kernel - Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in scsi_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a35b728d-90c8-60dc-04d1-d1762f26b8a2@huaweicloud.com>
Date:   Wed, 8 Mar 2023 09:15:40 +0800
From:   zhongjinghua <zhongjinghua@...weicloud.com>
To:     Bart Van Assche <bvanassche@....org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhongjinghua@...weicloude.com, yi.zhang@...wei.com,
        yukuai3@...wei.com
Subject: Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in
 scsi_remove_target

Thanks for you adevice.

Jinghua

在 2023/3/8 6:35, Bart Van Assche 写道:
> On 3/6/23 04:16, Zhong Jinghua wrote:
>> +            /*
>> +             * If the reference count is already zero, skip this
>> +             * target is safe  because scsi_target_destroy()
>> +             * will wait until the host lock has been released
>> +             * before freeing starget.
>> +             */
>
> The above comment has grammatical issues and is confusing. I think the 
> comment that I suggested was much better than the above.
>
> Bart.
>