linux-kernel - Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1edq0jg2h.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 07 Mar 2023 18:40:48 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Lee Duncan <lduncan@...e.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Lee Duncan <leeman.duncan@...il.com>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Martin Wilck <mwilck@...e.com>, Hannes Reinecke <hare@...e.de>,
        Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Subject: Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD


Lee,

> My worry is that this won't always work. Looking at the code, the
> buffer sizes used for VPD pages include 8, 32, 64, and 252 bytes. I'm
> not sure how reading 255 bytes into an 8-byte buffer would work.

In the scsi_get_vpd_buf() case we will allocate a 255 byte buffer since
that's what scsi_get_vpd_size() returns for a VDASD.

And in the scsi_get_vpd_page() case, where a buffer already exists, we
clamp the INQUIRY size to the minimum of scsi_get_vpd_size() and the
buffer length provided by the caller.

-- 
Martin K. Petersen	Oracle Linux Engineering