linux-kernel - Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4ecf9eb-509a-84a6-8a9f-a3f5ea54ecac@suse.com>
Date:   Wed, 8 Mar 2023 10:41:51 -0800
From:   Lee Duncan <lduncan@...e.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Lee Duncan <leeman.duncan@...il.com>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Martin Wilck <mwilck@...e.com>, Hannes Reinecke <hare@...e.de>,
        Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Subject: Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD

On 3/7/23 15:40, Martin K. Petersen wrote:
> 
> Lee,
> 
>> My worry is that this won't always work. Looking at the code, the
>> buffer sizes used for VPD pages include 8, 32, 64, and 252 bytes. I'm
>> not sure how reading 255 bytes into an 8-byte buffer would work.
> 
> In the scsi_get_vpd_buf() case we will allocate a 255 byte buffer since
> that's what scsi_get_vpd_size() returns for a VDASD.
> 
> And in the scsi_get_vpd_page() case, where a buffer already exists, we
> clamp the INQUIRY size to the minimum of scsi_get_vpd_size() and the
> buffer length provided by the caller.
> 

Please add my Reviewed-by tag then.

-- 
Lee