linux-kernel - Re: [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2: add binding docmuent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30000009-cf05-988a-9817-97a7af36db37@starfivetech.com>
Date:   Tue, 7 Mar 2023 14:41:06 +0800
From:   Jack Zhu <jack.zhu@...rfivetech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Ripard <mripard@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <changhuang.liang@...rfivetech.com>
Subject: Re: [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2:
 add binding docmuent



On 2023/3/3 16:47, Krzysztof Kozlowski wrote:
> On 02/03/2023 10:19, jack.zhu wrote:
>> Add DT binding document for Starfive MIPI CSI2 receiver
> 
> Ehh... you have entire commit msg to explain what you do here. Yet there
> is nothing mentioning that you actually have Cadence MIPI CSI here.
> 
> Since you decided to add new bindings, you receive review matching new
> bindings. I don't think this is correct approach (duplicated bindings),
> but could work for me. However how are you going to solve all the points
> of my review?

Maybe I don't need to add the CSI yaml file, since it already exists on the Linux mainline.

> 
> Best regards,
> Krzysztof
>