linux-kernel - Re: [PATCH v5 12/12] riscv: dts: starfive: visionfive 2: Enable gmac device tree node

Open Source and information security mailing list archives

Message-ID: <99a9eccd-2886-832f-07e6-4ba620c522b5@starfivetech.com>
Date:   Tue, 7 Mar 2023 09:21:07 +0800
From:   Guo Samin <samin.guo@...rfivetech.com>
To:     Emil Renner Berthing <emil.renner.berthing@...onical.com>
CC:     <linux-riscv@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Richard Cochran <richardcochran@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Peter Geis <pgwipeout@...il.com>,
        Yanhong Wang <yanhong.wang@...rfivetech.com>
Subject: Re: [PATCH v5 12/12] riscv: dts: starfive: visionfive 2: Enable gmac
 device tree node


在 2023/3/6 21:04:28, Emil Renner Berthing 写道:
> On Fri, 3 Mar 2023 at 10:01, Samin Guo <samin.guo@...rfivetech.com> wrote:
>> From: Yanhong Wang <yanhong.wang@...rfivetech.com>
>>
>> Update gmac device tree node status to okay.
>>
>> Signed-off-by: Yanhong Wang <yanhong.wang@...rfivetech.com>
>> Signed-off-by: Samin Guo <samin.guo@...rfivetech.com>
>> ---
>>  .../dts/starfive/jh7110-starfive-visionfive-2.dtsi     | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> index c2aa8946a0f1..d1c409f40014 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> @@ -12,6 +12,8 @@
>>  / {
>>         aliases {
>>                 serial0 = &uart0;
>> +               ethernet0 = &gmac0;
>> +               ethernet1 = &gmac1;
> 
> Please sort these alphabetically.
Thanks, will fix.
> 
>>                 i2c0 = &i2c0;
>>                 i2c2 = &i2c2;
>>                 i2c5 = &i2c5;
>> @@ -92,6 +94,14 @@
>>         status = "okay";
>>  };
>>
>> +&gmac0 {
>> +       status = "okay";
>> +};
>> +
>> +&gmac1 {
>> +       status = "okay";
>> +};
> 
> Since you'll need to add to the gmac0 and gmac1 nodes in the board
> specific files too and it's only one line, consider just dropping this
> here and add the status = "okay" there instead.
> 
According to Andrew's suggestion, can I put the nodes of mdio and phy here?
>>  &i2c0 {
>>         clock-frequency = <100000>;
>>         i2c-sda-hold-time-ns = <300>;
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv

Best regards,
Samin
-- 
Best regards,
Samin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives