linux-kernel - Re: [PATCH] Fix IRQ issue by setting IRQ_DISABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Tz-SHQxNzx=eS8ex=3Hps0th5bTY+K1qSWrZqWC8ryv+d0RA@mail.gmail.com>
Date:   Tue, 7 Mar 2023 19:54:20 +0900
From:   Masahiro Honda <honda@...hatrax.com>
To:     Nuno Sá <noname.nuno@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix IRQ issue by setting IRQ_DISABLE_UNLAZY flag

On Mon, Mar 6, 2023 at 10:30 PM Nuno Sá <noname.nuno@...il.com> wrote:
>
> Hmmm this looks to be a very likely issue for any device having to
> brute force IRQ disabling by disabling the line (disable_irq()). That
> said, I think the commit message can (needs) to be improved. The
> message feels a bit confusing to me. Also, having a reference to
>
> commit e9849777d0e2 ("genirq: Add flag to force mask in
> disable_irq[_nosync]()")
>
> would be nice to give some background on why this can be an issue.
>
> Another thing that came to my mind is if the data is totally
> garbage/wrong or is it just some outstanding sample?
>
>
> Some research on this also seems to point that we should (need?) call
> irq_clear_status_flags(irq, IRQ_DISABLE_UNLAZY) when freeing the IRQ.
>

Thank you for your reply. I'll improve it.

> I also wonder if we should keep this out of the library and have a per
> device config? Sure, this won't make anything wrong but it will hurt
> performance. OTOH, even though no one else ever reported this before,
> it looks like this can be an issue for all of the supported sigma delta
> ADCs.
>

I'll also investigate it.