linux-kernel - Re: [PATCH] Fix IRQ issue by setting IRQ_DISABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Tz-SFbt2RAz3POMRoTHqz+tNyQOn3UsssZV9EvHUhhR+XJbQ@mail.gmail.com>
Date:   Mon, 27 Mar 2023 18:01:14 +0900
From:   Masahiro Honda <honda@...hatrax.com>
To:     Nuno Sá <noname.nuno@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix IRQ issue by setting IRQ_DISABLE_UNLAZY flag

Hi, Nuno

> On Mon, Mar 6, 2023 at 10:30 PM Nuno Sá <noname.nuno@...il.com> wrote:
> > Another thing that came to my mind is if the data is totally
> > garbage/wrong or is it just some outstanding sample?

I'm sorry for not answering your question. The data is the same as
the previous conversion even if the input voltage is changed. At this
time, a logic analyzer shows that the read operation is performed
immediately after the conversion is performed. The read operation
returns the previous conversion result because it is performed before
the completion of the conversion.

> > Some research on this also seems to point that we should (need?) call
> > irq_clear_status_flags(irq, IRQ_DISABLE_UNLAZY) when freeing the IRQ.

I have understood that I need to call irq_clear_status_flags. However,
I cannot find a code to free the IRQ in ad_sigma_delta.c and other
Sigma-Delta ADC driver source files. So, I would like to implement
only irq_set_status_flags.