linux-kernel - Re: [PATCH] ASoC: do not include pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230307113016.GS68926@ediswmail.ad.cirrus.com>
Date:   Tue, 7 Mar 2023 11:30:16 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
CC:     <perex@...ex.cz>, <tiwai@...e.com>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <james.schulman@...rus.com>,
        <david.rhodes@...rus.com>, <tanureal@...nsource.cirrus.com>,
        <rf@...nsource.cirrus.com>, <oder_chiou@...ltek.com>,
        <shengjiu.wang@...il.com>, <Xiubo.Lee@...il.com>,
        <festevam@...il.com>, <nicoleotsuka@...il.com>,
        <shawnguo@...nel.org>, <s.hauer@...gutronix.de>,
        <kernel@...gutronix.de>, <linux-imx@....com>,
        <cezary.rojewski@...el.com>,
        <pierre-louis.bossart@...ux.intel.com>,
        <peter.ujfalusi@...ux.intel.com>,
        <yung-chuan.liao@...ux.intel.com>,
        <ranjani.sridharan@...ux.intel.com>,
        <kai.vehmanen@...ux.intel.com>, <matthias.bgg@...il.com>,
        <srinivas.kandagatla@...aro.org>, <bgoswami@...cinc.com>,
        <vkoul@...nel.org>, <daniel.baluta@....com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <jarkko.nikula@...mer.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        <linuxppc-dev@...ts.ozlabs.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <sound-open-firmware@...a-project.org>,
        <linux-tegra@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] ASoC: do not include pm_runtime.h if not used

On Tue, Mar 07, 2023 at 12:30:22PM +0200, Claudiu Beznea wrote:
> Do not include pm_runtime.h header in files where runtime PM support is
> not implemented.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> ---
>  sound/soc/codecs/cs35l45.h                                | 1 -
> diff --git a/sound/soc/codecs/cs35l45.h b/sound/soc/codecs/cs35l45.h
> index 53fe9d2b7b15..0555702eac03 100644
> --- a/sound/soc/codecs/cs35l45.h
> +++ b/sound/soc/codecs/cs35l45.h
> @@ -11,7 +11,6 @@
>  #ifndef CS35L45_H
>  #define CS35L45_H
>  
> -#include <linux/pm_runtime.h>
>  #include <linux/regmap.h>
>  #include <linux/regulator/consumer.h>
>  

cs35l45 does already make use of some functions from that header,
and more support is in the process of being upstreamed. So this
part should be dropped.

Thanks,
Charles