linux-kernel - Re: [PATCH] ASoC: do not include pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef92dcac-cadd-b85e-d6ea-512684266e81@linaro.org>
Date:   Fri, 10 Mar 2023 07:29:04 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>, perex@...ex.cz,
        tiwai@...e.com, lgirdwood@...il.com, broonie@...nel.org,
        james.schulman@...rus.com, david.rhodes@...rus.com,
        tanureal@...nsource.cirrus.com, rf@...nsource.cirrus.com,
        oder_chiou@...ltek.com, shengjiu.wang@...il.com,
        Xiubo.Lee@...il.com, festevam@...il.com, nicoleotsuka@...il.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        linux-imx@....com, cezary.rojewski@...el.com,
        pierre-louis.bossart@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, yung-chuan.liao@...ux.intel.com,
        ranjani.sridharan@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        matthias.bgg@...il.com, bgoswami@...cinc.com, vkoul@...nel.org,
        daniel.baluta@....com, thierry.reding@...il.com,
        jonathanh@...dia.com, jarkko.nikula@...mer.com
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com, linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        sound-open-firmware@...a-project.org, linux-tegra@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH] ASoC: do not include pm_runtime.h if not used



On 07/03/2023 10:30, Claudiu Beznea wrote:
> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> index 41db6617e2ed..dc892fac4baa 100644
> --- a/sound/soc/qcom/lpass-sc7180.c
> +++ b/sound/soc/qcom/lpass-sc7180.c
> @@ -12,7 +12,6 @@
>   #include <linux/module.h>
>   #include <linux/of.h>
>   #include <linux/platform_device.h>
> -#include <linux/pm_runtime.h>
>   #include <dt-bindings/sound/sc7180-lpass.h>
>   #include <sound/pcm.h>
>   #include <sound/soc.h>
> diff --git a/sound/soc/qcom/lpass-sc7280.c b/sound/soc/qcom/lpass-sc7280.c
> index d43f480cbae3..ee4a4b553e74 100644
> --- a/sound/soc/qcom/lpass-sc7280.c
> +++ b/sound/soc/qcom/lpass-sc7280.c
> @@ -8,7 +8,6 @@
>   #include <linux/module.h>
>   #include <sound/pcm.h>
>   #include <sound/soc.h>
> -#include <linux/pm_runtime.h>
>   
>   #include <dt-bindings/sound/sc7180-lpass.h>

Has these been compile tested? the reason I ask is because both these 
drivers need SET_SYSTEM_SLEEP_PM_OPS macro from pm.h which was getting 
included from pm_runtime.h, now that is removed, am guessing it will 
cause a compile errors.

can you atleast replace this with pm.h instead of removing it totally?

--srini