[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJM55Z_mzzAW52RMC6cfgiKNLicF9ip74csbsrbikE3tN+taaw@mail.gmail.com>
Date: Tue, 7 Mar 2023 13:51:49 +0100
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: William Qiu <william.qiu@...rfivetech.com>
Cc: devicetree@...r.kernel.org, linux-mmc@...r.kernel.org,
linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Conor Dooley <conor.dooley@...rochip.com>,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v5 2/2] mmc: starfive: Add initialization of prev_err
On Tue, 7 Mar 2023 at 03:49, William Qiu <william.qiu@...rfivetech.com> wrote:
> Add a incremental updates to fix a bug that prev_err is uninitialized.
>
> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
> Reported-by: Dan Carpenter <error27@...il.com>
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> ---
> drivers/mmc/host/dw_mmc-starfive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-starfive.c b/drivers/mmc/host/dw_mmc-starfive.c
> index 40f5969b07a6..dab1508bf83c 100644
> --- a/drivers/mmc/host/dw_mmc-starfive.c
> +++ b/drivers/mmc/host/dw_mmc-starfive.c
> @@ -51,7 +51,7 @@ static int dw_mci_starfive_execute_tuning(struct dw_mci_slot *slot,
> struct dw_mci *host = slot->host;
> struct starfive_priv *priv = host->priv;
> int rise_point = -1, fall_point = -1;
> - int err, prev_err;
> + int err, prev_err = 0;
> int i;
> bool found = 0;
> u32 regval;
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Powered by blists - more mailing lists