linux-kernel - RE: [RFC PATCH V2 0/1] x86: cpu topology fix and question on x86_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2023 02:46:59 +0000
From:   "Brown, Len" <len.brown@...el.com>
To:     "Zhang, Rui" <rui.zhang@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "peterz@...radead.org" <peterz@...radead.org>
CC:     "zhang.jia@...ux.alibaba.com" <zhang.jia@...ux.alibaba.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: RE: [RFC PATCH V2 0/1] x86: cpu topology fix and question on
 x86_max_cores

Yes, On Intel, Linux should be able assert that CPUID.1F has exactly the same "level" definitions on all CPUs in the system -- no matter SMP or Hybrid processor.

This is what Thomas is asking for -- an architectural APIC-ID decoder -- not a future feature, but one that is already shipping.

With this decoder, we can parse the ACPI BIOS APIC/MADT.
As Peter asserts, the list of processors in the MADT has to work, else smpboot would not be working.

If we don't already have a check that the INIT to APIC-ID N really wakes up N, and not some other id,
It shouldn't be hard to add that sanity check...

Anyway, trusting the MADT, and CPUID.1F, we can determine from cpu0 if we are going to boot any SMT siblings or not.
Indeed, we know ahead of time all of the CPUID.1F levels, including the implicit which  level -- which CPUs are in which packages,
And thus how many packages.

-Len