linux-kernel - Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node if exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2023 10:51:51 +0200
From:   Svyatoslav Ryhel <clamor95@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node
 if exists

Ooof, my bad. I will resend v2 with fix asap.

ср, 8 бер. 2023 р. о 10:49 Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> пише:
>
> On 08/03/2023 09:46, Svyatoslav Ryhel wrote:
> > ср, 8 бер. 2023 р. о 10:44 Alexandre Belloni
> > <alexandre.belloni@...tlin.com> пише:
> >>
> >> Hello,
> >>
> >> the subject is not correct, please use the subsystem style
> >>
> >> On 08/03/2023 10:37:59+0200, Svyatoslav Ryhel wrote:
> >>> MAX77663 PMIC can have RTC on both 0x63 i2c address (like grouper)
> >>> which is main address but on some devices RTC is located on 0x48
> >>> i2c address (like p880 and p895 from LG). Lets add property to be
> >>> able to use alternative address if needed without breaking existing
> >>> bindings.
> >>>
> >>> Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> >>> ---
> >>>  drivers/rtc/rtc-max77686.c | 8 +++++++-
> >>>  1 file changed, 7 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> >>> index b0250d91fb00..218177375531 100644
> >>> --- a/drivers/rtc/rtc-max77686.c
> >>> +++ b/drivers/rtc/rtc-max77686.c
> >>> @@ -691,6 +691,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info)
> >>>  {
> >>>       struct device *parent = info->dev->parent;
> >>>       struct i2c_client *parent_i2c = to_i2c_client(parent);
> >>> +     int rtc_i2c_addr;
> >>>       int ret;
> >>>
> >>>       if (info->drv_data->rtc_irq_from_platform) {
> >>> @@ -714,8 +715,13 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info)
> >>>               goto add_rtc_irq;
> >>>       }
> >>>
> >>> +     ret = device_property_read_u32(parent, "maxim,rtc-i2c-address",
> >>> +                                    &rtc_i2c_addr);
> >>
> >> This property needs to be documented
> >>
> >
> > max776xx pmic has no yaml to document
>
> Of course it has, otherwise on what did I work?
>
> git grep max77686
>
>
> Best regards,
> Krzysztof
>