[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f1df5968-4322-3f67-3da8-c10ea50386a8@linaro.org>
Date: Wed, 8 Mar 2023 09:54:28 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Svyatoslav Ryhel <clamor95@...il.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v1] max77663-rtc: pass rtc address from device tree node
if exists
On 08/03/2023 09:37, Svyatoslav Ryhel wrote:
> MAX77663 PMIC can have RTC on both 0x63 i2c address (like grouper)
> which is main address but on some devices RTC is located on 0x48
> i2c address (like p880 and p895 from LG). Lets add property to be
> able to use alternative address if needed without breaking existing
> bindings.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Anyway this is not max77663 driver.
The property does not make sense in the context of max77686. Maybe for
max77802/77620 and 77714 would have... but still max77663 is not there.
Don't add properties for unrelated and unsupported devices.
Best regards,
Krzysztof
Powered by blists - more mailing lists