linux-kernel - Re: [PATCH 1/2] fork: allow CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230308111643.dfa5zgiumdairdhn@wittgenstein>
Date:   Wed, 8 Mar 2023 12:16:43 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andrei Vagin <avagin@...il.com>,
        Dmitry Safonov <dima@...sta.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Andrey Vagin <avagin@...nvz.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/2] fork: allow CLONE_NEWTIME in clone3 flags

On Wed, Mar 08, 2023 at 11:51:26AM +0100, Tobias Klauser wrote:
> Currently, calling clone3() with CLONE_NEWTIME in clone_args->flags
> fails with -EINVAL. This is because CLONE_NEWTIME intersects with
> CSIGNAL. However, CSIGNAL was deprecated when clone3 was introduced in
> commit 7f192e3cd316 ("fork: add clone3"), allowing re-use of that part
> of clone flags.
> 
> Fix this by explicitly allowing CLONE_NEWTIME in clone3_args_valid. This
> is also in line with the respective check in check_unshare_flags which
> allow CLONE_NEWTIME for unshare().
> 
> Fixes: 769071ac9f20 ("ns: Introduce Time Namespace")
> Cc: Andrey Vagin <avagin@...nvz.org>
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: stable@...r.kernel.org
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---

Oh I either forgot or missed that we use a CSIGNAL bit for
CLONE_NEWTIME. Looks good,

Reviewed-by: Christian Brauner <brauner@...nel.org>