linux-kernel - Re: [PATCH 1/2] fork: allow CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167827558168.733158.936883559456207607.b4-ty@kernel.org>
Date:   Wed,  8 Mar 2023 12:40:54 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Christian Brauner <brauner@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrei Vagin <avagin@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Andrey Vagin <avagin@...nvz.org>,
        stable@...r.kernel.org, Dmitry Safonov <0x7f454c46@...il.com>
Subject: Re: [PATCH 1/2] fork: allow CLONE_NEWTIME in clone3 flags

From: Christian Brauner (Microsoft) <brauner@...nel.org>


On Wed, 08 Mar 2023 11:51:26 +0100, Tobias Klauser wrote:
> Currently, calling clone3() with CLONE_NEWTIME in clone_args->flags
> fails with -EINVAL. This is because CLONE_NEWTIME intersects with
> CSIGNAL. However, CSIGNAL was deprecated when clone3 was introduced in
> commit 7f192e3cd316 ("fork: add clone3"), allowing re-use of that part
> of clone flags.
> 
> Fix this by explicitly allowing CLONE_NEWTIME in clone3_args_valid. This
> is also in line with the respective check in check_unshare_flags which
> allow CLONE_NEWTIME for unshare().
> 
> [...]

Thanks for fixing this. Applied, thanks! If someone has already picked this
up/prefers to carry it just let me know and I'll happily drop it,

[1/2] fork: allow CLONE_NEWTIME in clone3 flags
      commit: a402f1e35313fc7ce2ca60f543c4402c2c7c3544
[2/2] selftests/clone3: test clone3 with CLONE_NEWTIME
      commit: 515bddf0ec4155cbd666d72daf5bd68c8b7cd987

Thanks!
Christian