linux-kernel - Re: [PATCH RESEND net-next v4 0/4] net/mlx5e: Add GBP VxLAN HW offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9996b21-c33c-d5af-32c1-abf6dc89b04b@intel.com>
Date:   Thu, 9 Mar 2023 17:33:14 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Simon Horman <simon.horman@...igine.com>
CC:     Gavin Li <gavinl@...dia.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <roopa@...dia.com>, <eng.alaamohamedsoliman.am@...il.com>,
        <bigeasy@...utronix.de>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <gavi@...dia.com>,
        <roid@...dia.com>, <maord@...dia.com>, <saeedm@...dia.com>
Subject: Re: [PATCH RESEND net-next v4 0/4] net/mlx5e: Add GBP VxLAN HW
 offload support

From: Simon.horman@...igine.com <simon.horman@...igine.com>
Date: Wed, 8 Mar 2023 21:13:31 +0100

> On Wed, Mar 08, 2023 at 02:34:28PM +0100, Alexander Lobakin wrote:
>> From: Gavin Li <gavinl@...dia.com>
>> Date: Wed, 8 Mar 2023 10:22:36 +0800

[...]

>>> Any comments, Simon?
>>>
>>> If both or you are OK with option #1, I'll follow.
> 
> I'd like suggest moving on from the who said what aspect of this conversation.
> Clearly there has been some misunderstanding. Let's move on.
> 
> Regarding the more technical topic of constness.
> Unless I am mistaken function in question looks like this:
> 
> static inline void *ip_tunnel_info_opts(const struct ip_tunnel_info *info)
> {
>      return info + 1;
> }
> 
> My view is that if the input is const, the output should be const;
> conversely, if the output is non-const then the input should be non-const.
> 
> It does seem to me that container_of_const has this property.
> And from that perspective may be the basis of a good solution.
> 
> This is my opinion. I do understand that others may have different opinions.

Mine is basically the very same :)

Thanks,
Olek