linux-kernel - Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAlY7jsj4daalgcY@bombadil.infradead.org>
Date:   Wed, 8 Mar 2023 19:56:30 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     ye.xingchen@....com.cn
Cc:     keescook@...omium.org, yzaikin@...gle.com,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact_memory interface

On Thu, Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@....com.cn wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Available only when CONFIG_COMPACTION is set. When 1 is written to
> the file, all zones are compacted such that free memory is available
> in contiguous blocks where possible.
> But echo others-parameter > compact_memory, this function will be
> triggered by writing parameters to the interface.
> 
> Applied this patch,
> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
> sh/$ sh: write error: Invalid argument

Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?

Why kill that? Did the docs say only 1 was possible? If not
perhaps the docs need to be updated?

  Luis