linux-kernel - Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230310015443.175552-1-ye.xingchen@zte.com.cn>
Date:   Fri, 10 Mar 2023 01:54:43 +0000
From:   ye xingchen <yexingchen116@...il.com>
To:     mcgrof@...nel.org
Cc:     akpm@...ux-foundation.org, keescook@...omium.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, ye.xingchen@....com.cn, yzaikin@...gle.com,
        chi.minghao@....com.cn
Subject: Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact_memory interface

>> From: Minghao Chi <chi.minghao@....com.cn>
>> 
>> Available only when CONFIG_COMPACTION is set. When 1 is written to
>> the file, all zones are compacted such that free memory is available
>> in contiguous blocks where possible.
>> But echo others-parameter > compact_memory, this function will be
>> triggered by writing parameters to the interface.
>> 
>> Applied this patch,
>> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
>> sh/$ sh: write error: Invalid argument
>
>Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?
yes
>
>Why kill that? Did the docs say only 1 was possible? If not
>perhaps the docs need to be updated?
In Documentation/admin-guide/sysctl/vm.rst:109 say: when 1 is written
to the file, all zones are compacted such that free memory is available
in contiguous blocks where possible.
So limit the value of interface compact_memory to 1.

Chi, and Ye