linux-kernel - Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Mar 2023 09:10:56 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Aakarsh Jain <aakarsh.jain@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     m.szyprowski@...sung.com, andrzej.hajda@...el.com,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        ezequiel@...guardiasur.com.ar, jernej.skrabec@...il.com,
        benjamin.gaignard@...labora.com, krzysztof.kozlowski+dt@...aro.org,
        stanimir.varbanov@...aro.org, dillon.minfei@...il.com,
        david.plowman@...pberrypi.com, mark.rutland@....com,
        robh+dt@...nel.org, krzk+dt@...nel.org, andi@...zian.org,
        alim.akhtar@...sung.com, aswani.reddy@...sung.com,
        pankaj.dubey@...sung.com
Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to
 json-schema

On 09/03/2023 08:22, Aakarsh Jain wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
>> Sent: 09 March 2023 12:15
>> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
>> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
>> kernel@...r.kernel.org; devicetree@...r.kernel.org
>> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
>> mchehab@...nel.org; hverkuil-cisco@...all.nl;
>> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
>> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
>> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
>> david.plowman@...pberrypi.com; mark.rutland@....com;
>> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
>> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
>> pankaj.dubey@...sung.com
>> Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-
>> schema
>>
>> On 02/03/2023 16:18, Aakarsh Jain wrote:
>>>>
>>>> iommus:
>>>>   maxItems: 1
>>>> iommu-names: false
>>>>
>>> I am getting compilation errors with above property set and its breaking the
>> bindings.
>>> If we see these two nodes in dtsi files.
>>>                mfc: codec@...00000 {
>>>                         compatible = "samsung,mfc-v5"; ..
>>>                         iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
>>>                         iommu-names = "left", "right"; } And
>>>               mfc: codec@...00000 {
>>>                         compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
>>>                         reg = <0x13400000 0x10000>; ...
>>>                         iommus = <&sysmmu_mfc>;
>>>                 };
>>> There is no iommu-names property for compatible "samsung,exynos3250-
>> mfc, samsung,mfc-v7", that’s why I kept
>>>         iommus:
>>>           minItems: 1
>>>           maxItems: 2
>>> I would even go with below if you agree?
>>>         iommus:
>>>           minItems: 1
>>>           maxItems: 2
>>>         iommus-names: false
>>
>> No, I don't agree. Why do you need two IOMMUs for Exynos3250?
>>>
> Here IOMMUs minItems:1 is meant for Exynos3250 while IOMMUs maxItems:2 meant for samsung,mfc-v5(Exynos 4).
> As you suggested 
> iommus:
>   maxItems: 1
> iommu-names: false
> 
> won't fit here.
> Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone will also break the bindings. Thanks why suggested
>          iommus:
>            minItems: 1
>            maxItems: 2

Are you sure you are putting this in correct place? This is if:then for
Exynos3250, isn't it?

Best regards,
Krzysztof