linux-kernel - RE: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001901d95263$eac4b460$c04e1d20$@samsung.com>
Date:   Thu, 9 Mar 2023 14:18:23 +0530
From:   "Aakarsh Jain" <aakarsh.jain@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Cc:     <m.szyprowski@...sung.com>, <andrzej.hajda@...el.com>,
        <mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
        <ezequiel@...guardiasur.com.ar>, <jernej.skrabec@...il.com>,
        <benjamin.gaignard@...labora.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <stanimir.varbanov@...aro.org>, <dillon.minfei@...il.com>,
        <david.plowman@...pberrypi.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <andi@...zian.org>,
        <alim.akhtar@...sung.com>, <aswani.reddy@...sung.com>,
        <pankaj.dubey@...sung.com>
Subject: RE: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to
 json-schema



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 09 March 2023 13:41
> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
> david.plowman@...pberrypi.com; mark.rutland@....com;
> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
> pankaj.dubey@...sung.com
> Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-
> schema
> 
> On 09/03/2023 08:22, Aakarsh Jain wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> >> Sent: 09 March 2023 12:15
> >> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
> >> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
> >> kernel@...r.kernel.org; devicetree@...r.kernel.org
> >> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
> >> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> >> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
> >> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
> >> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
> >> david.plowman@...pberrypi.com; mark.rutland@....com;
> >> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
> >> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
> >> pankaj.dubey@...sung.com
> >> Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings
> >> to json- schema
> >>
> >> On 02/03/2023 16:18, Aakarsh Jain wrote:
> >>>>
> >>>> iommus:
> >>>>   maxItems: 1
> >>>> iommu-names: false
> >>>>
> >>> I am getting compilation errors with above property set and its
> >>> breaking the
> >> bindings.
> >>> If we see these two nodes in dtsi files.
> >>>                mfc: codec@...00000 {
> >>>                         compatible = "samsung,mfc-v5"; ..
> >>>                         iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
> >>>                         iommu-names = "left", "right"; } And
> >>>               mfc: codec@...00000 {
> >>>                         compatible = "samsung,exynos3250-mfc", "samsung,mfc-
> v7";
> >>>                         reg = <0x13400000 0x10000>; ...
> >>>                         iommus = <&sysmmu_mfc>;
> >>>                 };
> >>> There is no iommu-names property for compatible
> "samsung,exynos3250-
> >> mfc, samsung,mfc-v7", that’s why I kept
> >>>         iommus:
> >>>           minItems: 1
> >>>           maxItems: 2
> >>> I would even go with below if you agree?
> >>>         iommus:
> >>>           minItems: 1
> >>>           maxItems: 2
> >>>         iommus-names: false
> >>
> >> No, I don't agree. Why do you need two IOMMUs for Exynos3250?
> >>>
> > Here IOMMUs minItems:1 is meant for Exynos3250 while IOMMUs
> maxItems:2 meant for samsung,mfc-v5(Exynos 4).
> > As you suggested
> > iommus:
> >   maxItems: 1
> > iommu-names: false
> >
> > won't fit here.
> > Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone
> will also break the bindings. Thanks why suggested
> >          iommus:
> >            minItems: 1
> >            maxItems: 2
> 
> Are you sure you are putting this in correct place? This is if:then for
> Exynos3250, isn't it?
> 
Its not only for Exynos3250, its along with Exynos4 since their clock properties are same
allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - samsung,mfc-v5        #Exynos4
              - samsung,exynos3250-mfc
    then:
      properties:
        clocks:
          maxItems: 2
        clock-names:
          items:
            - const: mfc
            - const: sclk_mfc
        iommus:
          minItems: 1
          maxItems: 2

or do I keep different if:then condition for both Exynos3250 and Exynos4 for IOMMUs property ?

> Best regards,
> Krzysztof