[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49106943-450a-11c0-99ce-159d40471bf2@linaro.org>
Date: Fri, 10 Mar 2023 10:08:02 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Aakarsh Jain <aakarsh.jain@...sung.com>,
linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc: m.szyprowski@...sung.com, andrzej.hajda@...el.com,
mchehab@...nel.org, hverkuil-cisco@...all.nl,
ezequiel@...guardiasur.com.ar, jernej.skrabec@...il.com,
benjamin.gaignard@...labora.com, krzysztof.kozlowski+dt@...aro.org,
stanimir.varbanov@...aro.org, dillon.minfei@...il.com,
david.plowman@...pberrypi.com, mark.rutland@....com,
robh+dt@...nel.org, krzk+dt@...nel.org, andi@...zian.org,
alim.akhtar@...sung.com, aswani.reddy@...sung.com,
pankaj.dubey@...sung.com
Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to
json-schema
On 09/03/2023 09:48, Aakarsh Jain wrote:
>>> won't fit here.
>>> Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone
>> will also break the bindings. Thanks why suggested
>>> iommus:
>>> minItems: 1
>>> maxItems: 2
>>
>> Are you sure you are putting this in correct place? This is if:then for
>> Exynos3250, isn't it?
>>
> Its not only for Exynos3250, its along with Exynos4 since their clock properties are same
> allOf:
> - if:
> properties:
> compatible:
> contains:
> enum:
> - samsung,mfc-v5 #Exynos4
> - samsung,exynos3250-mfc
> then:
> properties:
> clocks:
> maxItems: 2
> clock-names:
> items:
> - const: mfc
> - const: sclk_mfc
> iommus:
> minItems: 1
> maxItems: 2
>
> or do I keep different if:then condition for both Exynos3250 and Exynos4 for IOMMUs property ?
Yes, they should be split into two if-then.
Best regards,
Krzysztof
Powered by blists - more mailing lists