linux-kernel - Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 09 Mar 2023 12:30:33 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Mark Brown" <broonie@...nel.org>
Cc:     "Ye Xiang" <xiang.ye@...el.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Matthias Kaehlcke" <mka@...omium.org>,
        "Lee Jones" <lee@...nel.org>, "Wolfram Sang" <wsa@...nel.org>,
        "Tyrone Ting" <kfting@...oton.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Bartosz Golaszewski" <brgl@...ev.pl>, linux-usb@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        srinivas.pandruvada@...el.com, heikki.krogerus@...ux.intel.com,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
        zhifeng.wang@...el.com, wentong.wu@...el.com, lixu.zhang@...el.com
Subject: Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device

On Thu, Mar 9, 2023, at 12:03, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 08:56:05AM +0100, Arnd Bergmann wrote:
>> On Thu, Mar 9, 2023, at 08:10, Ye Xiang wrote:
>
>> >  drivers/usb/misc/Kconfig  |  13 +
>> >  drivers/usb/misc/Makefile |   1 +
>> >  drivers/usb/misc/ljca.c   | 969 ++++++++++++++++++++++++++++++++++++++
>> >  include/linux/mfd/ljca.h  |  95 ++++
>
>> Why is this in driver/usb/misc? It looks like a normal
>> mfd driver to me, and it evenhas the header in include/linux/mfd/
>
> It was a MFD in the original version, Lee asked for it to be moved to
> USB: https://lore.kernel.org/r/20230305103456.GF2574592@google.com

Ok, I see. That should probably be mentioned in the patch
description then. I'm still not sure I follow the reasoning
for the split between "usb functionality" and and mfd part:
This is just a usb driver as it is attached to a usb bus, and
drivers usually get put into a directory based on what they
provide, not how they are attached to a parent bus.

    Arnd