[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=MdAQ27K_tm2+pzQULo7NtV4wUBPM3fX-9a+snXWTQUh0A@mail.gmail.com>
Date: Fri, 10 Mar 2023 16:54:44 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/2] gpio: sim: Deactivate device in reversed order
On Thu, Mar 9, 2023 at 7:46 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Run the steps to deactivate device in the reserved order to what
> it has been done in gpio_sim_device_activate_unlocked().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/gpio/gpio-sim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index e5dfd636c63c..a1c8702f362c 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -953,9 +953,9 @@ static void gpio_sim_device_deactivate_unlocked(struct gpio_sim_device *dev)
>
> swnode = dev_fwnode(&dev->pdev->dev);
> platform_device_unregister(dev->pdev);
> + gpio_sim_remove_hogs(dev);
> gpio_sim_remove_swnode_recursive(swnode);
> dev->pdev = NULL;
> - gpio_sim_remove_hogs(dev);
> }
>
> static ssize_t
> --
> 2.39.1
>
Meh, doesn't really fix any problem but applied anyway for consistency.
Thanks,
Bart
Powered by blists - more mailing lists