linux-kernel - Re: [PATCH v1 2/2] gpio: sim: Print boolean as unsigned integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 16:56:19 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 2/2] gpio: sim: Print boolean as unsigned integer

On Thu, Mar 9, 2023 at 7:46 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Print boolean as unsigned integer instead of using %c and manually
> converting to a character.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpio-sim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index a1c8702f362c..5ac1de5db751 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -684,7 +684,7 @@ gpio_sim_device_config_live_show(struct config_item *item, char *page)
>         live = gpio_sim_device_is_live_unlocked(dev);
>         mutex_unlock(&dev->lock);
>
> -       return sprintf(page, "%c\n", live ? '1' : '0');
> +       return sprintf(page, "%u\n", live);
>  }
>
>  static char **gpio_sim_make_line_names(struct gpio_sim_bank *bank,
> --
> 2.39.1
>

Sorry but NACK. At first glance the current version is more readable.
With the one you're proposing, I need to look at the type of "live" to
understand what it will print.

Bart