linux-kernel - [BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit declaration of function ‘amd_pmc_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230309224451.13b9648b@gandalf.local.home>
Date:   Thu, 9 Mar 2023 22:44:51 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        platform-driver-x86@...r.kernel.org
Subject: [BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit declaration
 of function ‘amd_pmc_write_stb’

Someone on the linux-rt IRC channel complained of a build failure for
6.3-rc1-rt1, but investigating it further, the build failure exists in
6.3-rc1 vanilla.

With CONFIG_SUSPEND not defined I get:

drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_stb_debugfs_open_v2’:
drivers/platform/x86/amd/pmc.c:256:15: error: implicit declaration of function ‘amd_pmc_write_stb’; did you mean ‘amd_pmc_read_stb’? [-Werror=implicit-function-declaration]
  256 |         ret = amd_pmc_write_stb(dev, AMD_PMC_STB_DUMMY_PC);
      |               ^~~~~~~~~~~~~~~~~
      |               amd_pmc_read_stb

I see in that file:

#ifdef CONFIG_SUSPEND
static int amd_pmc_write_stb(struct amd_pmc_dev *dev, u32 data)
{
[...]
}
#endif

And that commit b0d4bb973539 ("platform/x86/amd: pmc: Write dummy postcode
into the STB DRAM") adds a call to amd_pmc_write_stb() right were that
error is, without any protection against CONFIG_SUSPEND.

Try it! Build AMD/pmc.c without CONFIG_SUSPEND to enjoy the same build
message as I received.

-- Steve