linux-kernel - Re: [BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit declaration of function ‘amd_pmc_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230309225016.2e8cd211@gandalf.local.home>
Date:   Thu, 9 Mar 2023 22:50:16 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        platform-driver-x86@...r.kernel.org
Subject: Re: [BUILD BUG v6.3-rc1] platform/x86/amd: error: implicit
 declaration of function ‘amd_pmc_write_stb’

On Thu, 9 Mar 2023 22:44:51 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> With CONFIG_SUSPEND not defined I get:
> 
> drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_stb_debugfs_open_v2’:
> drivers/platform/x86/amd/pmc.c:256:15: error: implicit declaration of function ‘amd_pmc_write_stb’; did you mean ‘amd_pmc_read_stb’? [-Werror=implicit-function-declaration]
>   256 |         ret = amd_pmc_write_stb(dev, AMD_PMC_STB_DUMMY_PC);
>       |               ^~~~~~~~~~~~~~~~~
>       |               amd_pmc_read_stb
> 

And I just checked out Linus's top of tree and see that all the
CONFIG_SUSPEND defines are removed from that file.

As the Church Lady use to say...

     Never mind!

-- Steve