lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 10 Mar 2023 15:28:48 -0500
From:   Tom Rix <trix@...hat.com>
To:     broonie@...nel.org
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] Revert "spi: fsi: Make available for build test"

This reverts commit f916c7080d28831493518364492e33fc6a437907.

A rand config causes this link error
drivers/spi/spi-fsi.o: In function `fsi_spi_probe':
spi-fsi.c:(.text+0x2c): undefined reference to `fsi_slave_read'

The rand config has
CONFIG_SPI_FSI=y
CONFIG_COMPILE_TEST=y
CONFIG_OF=n
CONFIG_FSI=n

Building fails unless FSI is enabled, so using || COMPILE_TEST is a mistake.

Fixes: f916c7080d28 ("spi: fsi: Make available for build test")
Signed-off-by: Tom Rix <trix@...hat.com>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 36a18c215163..80f3cade6006 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -357,7 +357,7 @@ config SPI_FALCON
 
 config SPI_FSI
 	tristate "FSI SPI driver"
-	depends on FSI || COMPILE_TEST
+	depends on FSI
 	help
 	  This enables support for the driver for FSI bus attached SPI
 	  controllers.
-- 
2.27.0

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ