lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <303e2cef-4568-26b9-a76f-1b6d5206bd7e@alu.unizg.hr>
Date:   Fri, 10 Mar 2023 21:46:26 +0100
From:   Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Mirsad Goran Todorovac <mirsad.goran.todorovac@....hr>,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        Paul Moore <paul@...l-moore.com>,
        Casey Schaufler <casey@...aufler-ca.com>,
        Christian Göttsche <cgzones@...glemail.com>,
        Mickaël Salaün <mic@...ikod.net>,
        Frederick Lawler <fred@...udflare.com>
Subject: Re: [PATCH v1 1/2] Add release hook to LSM

On 10. 03. 2023. 21:12, Andy Shevchenko wrote:
> On Fri, Mar 10, 2023 at 08:52:32PM +0100, Mirsad Goran Todorovac wrote:
>> On 10. 03. 2023. 20:47, Andy Shevchenko wrote:
>>> On Fri, Mar 10, 2023 at 08:42:00PM +0100, Mirsad Goran Todorovac wrote:
>>>>
>>>> Add release() hook to the definition of the LSM modules, to enable calling
>>>> destructors and deallocating allocated resources cleanly.
>>>>
>>>> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
>>>
>>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>>
>>> I haven't given you this tag. Sorry, you must not add something
>>> which was not explicitly given.
>>
>> Mea culpa.
>>
>> I misunderstood that you have approved the change when saying that I should
>> file a formal patch. It worked with Florian Westphal in my first patch, so I
>> thought it would be inappropriate to leave out who endorsed the patch.
> 
> We have Suggested-by tag for that.

Yes, I think that's what is right.

I agree that it is inappropriate to add something that was not
explicitly given. It's your tag and you define the rules. :-)

>> Thousand apologies. This is my second patch, so I am asking for some extra
>> grace ...
> 
>> What should I do now?
> 
> Wait at least a couple of days (even more, since it's weekend) for other
> comments and then send a v2 of the series with the comments addressed.

Will do. It is better done right than tonight.

> Btw, you may take my "smart" script [1] for sending patch series. It
> makes much less headache on how to do that properly.
> 
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

You should please understand that sometimes I simply block or deadlock on
some very simple things. I have not yet implemented RCUs but rely on
evil spinlocks :-)

Thanks again. Then I'll take a beer and chill out a bit. Perhaps sniff
around if something else is left without a destructor or a release hook,
too.

However, it might be too daring to go straight into the LSM area. I am
strongly depending on your experience and mentoring, and yes, you define
the rules for assisting your team.

I just hope I did not break the Rules of Conduct. Tried to Cc: as many
maintainers as I could.

They said that every beginning is hard. But no pain, no gain :-/

Regards,
Mirsad

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
 
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ