linux-kernel - Re: [PATCH] drivers: iio: remove dead code in at91_adc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b4ff6bf-3ba3-10bd-f766-c1e8cb34a111@microchip.com>
Date:   Fri, 10 Mar 2023 09:55:11 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <dzm91@...t.edu.cn>
CC:     <chengziqiu@...t.edu.cn>, <eugen.hristev@...labora.com>,
        <jic23@...nel.org>, <lars@...afoo.de>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe

On 10.03.2023 11:41, 慕冬亮 wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> -----原始邮件-----
>> 发件人: Claudiu.Beznea@...rochip.com
>> 发送时间: 2023-03-10 17:14:56 (星期五)
>> 收件人: chengziqiu@...t.edu.cn, eugen.hristev@...labora.com, jic23@...nel.org, lars@...afoo.de, Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com
>> 抄送: dzm91@...t.edu.cn, linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
>> 主题: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
>>
>> On 09.03.2023 17:05, Cheng Ziqiu wrote:
>>> >From the comment of platform_get_irq, it only returns non-zero IRQ
>>> number and negative error number, other than zero.
>>>
>>> Fix this by removing the if condition.
>>>
>>> Signed-off-by: Cheng Ziqiu <chengziqiu@...t.edu.cn>
>>
>> I see From and 1st SoB matches but
>>
>>> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
>>
>> this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
> 
> I reviewed this patch locally since this student is the first time to submit patch to the kernel mailing list.

Then please use "Reviewed-by" tag.

> 
> In my lab, I encourage all students to fix kernel issues. However, their patches should be reviewed by me first before sending the mailing list.
> 
>>
>>> ---
>>>  drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
>>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
>>> index 50d02e5fc6fc..168399092590 100644
>>> --- a/drivers/iio/adc/at91-sama5d2_adc.c
>>> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
>>> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
>>>         st->dma_st.phys_addr = res->start;
>>>
>>>         st->irq = platform_get_irq(pdev, 0);
>>> -       if (st->irq <= 0) {
>>> -               if (!st->irq)
>>> -                       st->irq = -ENXIO;
>>> -
>>> +       if (st->irq < 0)
>>>                 return st->irq;
>>> -       }
>>>
>>>         st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
>>>         if (IS_ERR(st->per_clk))
>>> --
>>> 2.34.1
>>>
>>
> 
> 
> --
> Best regards,
> Dongliang Mu