linux-kernel - Re: [PATCH v3 17/20] nvmem: layouts: sl28vpd: Add new layout driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230310121602.109c58e7@xps-13>
Date:   Fri, 10 Mar 2023 12:16:02 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Walle <michael@...le.cc>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Robert Marko <robert.marko@...tura.hr>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v3 17/20] nvmem: layouts: sl28vpd: Add new layout driver

Hi Srinivas,

srinivas.kandagatla@...aro.org wrote on Fri, 10 Mar 2023 11:03:45 +0000:

> On 08/03/2023 15:31, Miquel Raynal wrote:
> > +
> > +static int __init sl28vpd_init(void)
> > +{
> > +	return nvmem_layout_register(&sl28vpd_layout);
> > +}
> > +
> > +static void __exit sl28vpd_exit(void)
> > +{
> > +	nvmem_layout_unregister(&sl28vpd_layout);
> > +}
> > +
> > +module_init(sl28vpd_init);
> > +module_exit(sl28vpd_exit);  
> Looking at this pattern in two drivers, we could come up with some helper macro like.
> 
> #define module_nvmem_layout_driver(__layout_driver) \
>          module_driver(__layout_driver, nvmem_layout_register, \
>                          nvmem_layout_unregister)

Nice idea! I will make a patch; is it okay do it on top?

Thanks,
Miquèl