linux-kernel - Re: [PATCH v3 09/20] nvmem: core: introduce NVMEM layouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6762585dbd135a641a9bd2ff9f15697@milecki.pl>
Date:   Fri, 10 Mar 2023 12:00:20 +0100
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Walle <michael@...le.cc>,
        Robert Marko <robert.marko@...tura.hr>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v3 09/20] nvmem: core: introduce NVMEM layouts

On 2023-03-10 11:55, Srinivas Kandagatla wrote:
> On 08/03/2023 15:31, Miquel Raynal wrote:
>> +const void *nvmem_layout_get_match_data(struct nvmem_device *nvmem,
>> +					struct nvmem_layout *layout)
>> +{
>> +	struct device_node __maybe_unused *layout_np;
>> +	const struct of_device_id *match;
>> +
>> +	layout_np = of_nvmem_layout_get_container(nvmem);
>> +	match = of_match_node(layout->of_match_table, layout_np);
>> +
>> +	return match ? match->data : NULL;
>> +}
>> +EXPORT_SYMBOL_GPL(nvmem_layout_get_match_data);
> 
> who is the user of this function, in the current patchset I see none?

This will be required for the U-Boot env layout, see:
[PATCH V3 4/6] nvmem: u-boot-env: convert to layout driver


> On the other hand interpretation of match data is pretty much driver
> specific i see no reason for this to be in core.

Interpretation: yes. It's driver specific.

Getting that struct however belongs to the core. We have all kind of
helpers for getting driver private data. Those helpers live in some core
code of subsystems.