linux-kernel - Re: [PATCH 1/2] crypto: caam - reduce page 0 regs access to minimum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAsRxvI71MvsbNMp@gondor.apana.org.au>
Date:   Fri, 10 Mar 2023 19:17:26 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     meenakshi.aggarwal@....com
Cc:     horia.geanta@....com, V.sethi@....com, pankaj.gupta@....com,
        gaurav.jain@....com, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] crypto: caam - reduce page 0 regs access to minimum

On Thu, Mar 02, 2023 at 11:50:54AM +0530, meenakshi.aggarwal@....com wrote:
> From: Horia GeantA <horia.geanta@....com>
> 
> Use job ring register map, in place of controller register map
> to access page 0 registers, as access to the controller register
> map is not permitted.
> 
> Signed-off-by: Horia GeantA <horia.geanta@....com>
> ---
>  drivers/crypto/caam/caamalg.c  | 21 +++++-----
>  drivers/crypto/caam/caamhash.c | 10 +++--
>  drivers/crypto/caam/caampkc.c  |  6 +--
>  drivers/crypto/caam/caamrng.c  |  6 +--
>  drivers/crypto/caam/ctrl.c     | 74 +++++++++++++++++++++-------------
>  drivers/crypto/caam/debugfs.c  |  8 ++--
>  drivers/crypto/caam/debugfs.h  |  7 +++-
>  7 files changed, 78 insertions(+), 54 deletions(-)

With these two patches I get:

  CHECK   ../drivers/crypto/caam/ctrl.c
../drivers/crypto/caam/ctrl.c:706:27: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:705:27: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:705:17: warning: incorrect type in assignment (different address spaces)
../drivers/crypto/caam/ctrl.c:705:17:    expected struct caam_perfmon [noderef] __iomem *perfmon
../drivers/crypto/caam/ctrl.c:705:17:    got struct caam_perfmon *
../drivers/crypto/caam/ctrl.c:836:37: warning: incorrect type in argument 2 (different address spaces)
../drivers/crypto/caam/ctrl.c:836:37:    expected struct caam_perfmon *perfmon
../drivers/crypto/caam/ctrl.c:836:37:    got struct caam_perfmon [noderef] __iomem *perfmon
../drivers/crypto/caam/ctrl.c:881:32: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:880:32: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:880:22: warning: incorrect type in assignment (different address spaces)
../drivers/crypto/caam/ctrl.c:880:22:    expected struct version_regs [noderef] __iomem *vreg
../drivers/crypto/caam/ctrl.c:880:22:    got struct version_regs *
../drivers/crypto/caam/ctrl.c:450: warning: Function parameter or member 'perfmon' not described in 'caam_get_era'
../drivers/crypto/caam/ctrl.c:450: warning: Excess function parameter 'ctrl' description in 'caam_get_era'

Please always make sure your code compiles cleanly with C=1 W=1.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt