linux-kernel - Re: [PATCH v3 7/9] crypto: ccp: Add support for ringing a platform doorbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 19:19:35 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Jan Dąbroś <jsd@...ihalf.com>,
        Grzegorz Bernacki <gjb@...ihalf.com>, Rijo-john.Thomas@....com,
        Thomas.Lendacky@....com, John Allen <john.allen@....com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/9] crypto: ccp: Add support for ringing a platform
 doorbell

On Fri, Mar 03, 2023 at 10:50:45AM -0600, Mario Limonciello wrote:
> Some platforms support using a doorbell to communicate. Export
> this feature for other drivers to utilize as well.
> 
> Link: https://lore.kernel.org/linux-i2c/20220916131854.687371-3-jsd@semihalf.com/
> Suggested-by: Jan Dabros <jsd@...ihalf.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v2->v3:
>  * Squash register values in
>  * Use command and button registers
>  * Correct register values for incorrect ones previously shared
>  * Use a unique mutex
> v1->v2:
>  * New patch
> ---
>  drivers/crypto/ccp/platform-access.c | 52 ++++++++++++++++++++++++++++
>  drivers/crypto/ccp/platform-access.h |  1 +
>  drivers/crypto/ccp/sp-dev.h          |  3 ++
>  drivers/crypto/ccp/sp-pci.c          |  2 ++
>  include/linux/psp-platform-access.h  | 15 ++++++++
>  include/linux/psp.h                  |  3 ++
>  6 files changed, 76 insertions(+)

With this patch I get:

  CHECK   ../drivers/crypto/ccp/platform-access.c
../drivers/crypto/ccp/platform-access.c:59:27: warning: duplicate [noderef]
../drivers/crypto/ccp/platform-access.c:59:27: error: multiple address spaces given: __iomem & __iomem
../drivers/crypto/ccp/platform-access.c:59:40: error: multiple address spaces given: __iomem & __iomem
../drivers/crypto/ccp/platform-access.c:139:30: error: multiple address spaces given: __iomem & __iomem

Please ensure that your code compiles cleanly with C=1 W=1 before
you submit.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt